Enable multiple installations by not failing if all existing default resources exists #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzaadi
force-pushed
the
PORT-11373-happy-path-in-multiple-installations
branch
from
bea2a0c to
71fa39d
Compare
| } | ||
|
|
||
| if err := integration.CreateIntegration(portClient, config.StateKey, config.EventListenerType, defaults.AppConfig); err != nil { | ||
| klog.Warningf("Failed to create integration with default configuration. state key %s: %v", config.StateKey, err.Error()) | ||
| return &AbortDefaultCreationError{BlueprintsToRollback: createdBlueprints, PagesToRollback: createdPages, Errors: []error{err}} |
There was a problem hiding this comment.
why we would want to ignore a failure in this case?
erikzaadi
force-pushed
the
PORT-11373-happy-path-in-multiple-installations
branch
from
a0136aa to
e452993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align logic of default resource creation with ocean, AKA if all resources already exist, don't fail
Type of change